Add external certificate management for the Concierge Impersonation Proxy #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1582 +/- ##
=======================================
Coverage 75.48% 75.48%
=======================================
Files 166 166
Lines 15012 15083 +71
=======================================
+ Hits 11332 11386 +54
- Misses 3386 3399 +13
- Partials 294 298 +4
|
joshuatcasey
force-pushed
the
jtc/1547-poc
branch
5 times, most recently
from
6c721ac
to
dbb23b8
Compare
joshuatcasey
force-pushed
the
jtc/1547-poc
branch
from
dbb23b8
to
7fa1767
Compare
joshuatcasey
commented
Jul 20, 2023
joshuatcasey
commented
Jul 20, 2023
internal/controller/impersonatorconfig/impersonator_config_test.go
Outdated
Show resolved
Hide resolved
joshuatcasey
force-pushed
the
jtc/1547-poc
branch
2 times, most recently
from
96c3cb6
to
9e264dc
Compare
cfryanr
reviewed
Jul 28, 2023
cfryanr
reviewed
Jul 28, 2023
cfryanr
reviewed
Jul 28, 2023
cfryanr
reviewed
Jul 28, 2023
cfryanr
reviewed
Jul 28, 2023
cfryanr
reviewed
Jul 28, 2023
cfryanr
reviewed
Jul 28, 2023
cfryanr
reviewed
Jul 28, 2023
cfryanr
reviewed
Jul 28, 2023
joshuatcasey
force-pushed
the
jtc/1547-poc
branch
3 times, most recently
from
2b87a55
to
0faae51
Compare
cfryanr
approved these changes
Aug 2, 2023
benjaminapetersen
approved these changes
Aug 3, 2023
…rnetes.io/tls changes in the namespace
…rnally provided TLS secret
…an external TLS serving cert
…ind of valid cert
joshuatcasey
force-pushed
the
jtc/1547-poc
branch
from
0faae51
to
dc61d13
Compare
joshuatcasey
added a commit
that referenced
this pull request
Aug 9, 2023
…rets for the impersonation proxy
benjaminapetersen
added a commit
that referenced
this pull request
Aug 9, 2023
…-ca-crt Fix #1582 by not double-decoding the ca.crt field in external TLS secrets for the impersonation proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add external certificate management for the Concierge Impersonation Proxy
Resolves #1547 .
See the accepted proposal for the design considerations.
Working POC (with documented steps)This will happen in the blog post announcing the release