-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LDAPIdentityProvider.spec.groupSearch.userAttributeForFilter #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 75.39% 75.42% +0.03%
==========================================
Files 165 165
Lines 14942 14968 +26
==========================================
+ Hits 11265 11290 +25
- Misses 3383 3385 +2
+ Partials 294 293 -1
|
Add the field to the tmpl file and run codegen. Also update the count of the fields of our APIs in an integration test.
cfryanr
force-pushed
the
ldap_userAttributeForFilter
branch
from
May 25, 2023 16:52
ae4d6ac
to
bad5e60
Compare
Load the setting in the controller. Use the setting during authentication and during refreshes.
I manually tested the code committed so far on this WIP PR and it works. Next, need to write some integration tests, probably in
Some small tests could also be added to |
Integration tests added! |
cfryanr
changed the title
WIP: Add LDAPIdentityProvider.spec.groupSearch.userAttributeForFilter
Add LDAPIdentityProvider.spec.groupSearch.userAttributeForFilter
May 26, 2023
joshuatcasey
approved these changes
May 30, 2023
Also adds new integration test env var to support the new test: PINNIPED_TEST_LDAP_EXPECTED_DIRECT_POSIX_GROUPS_CN
cfryanr
force-pushed
the
ldap_userAttributeForFilter
branch
from
May 31, 2023 17:31
66c8649
to
552ecea
Compare
…Filter Add the field to the tmpl file and run codegen. Also update the count of the fields of our APIs in an integration test.
…earches - Load the setting in the controller. - The LDAP auth code is shared between AD and LDAP, so no new changes there in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1533.
Release note: