Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept both old and new cert error strings on MacOS in test assertions #1389

Merged
merged 2 commits into from
Jan 24, 2023

Commits on Jan 20, 2023

  1. Accept both old and new cert error strings on MacOS in test assertions

    Used this as an opportunity to refactor how some tests were
    making assertions about error strings.
    
    New test helpers make it easy for an error string to be expected as an
    exact string, as a string built using sprintf, as a regexp, or as a
    string built to include the platform-specific x509 error string.
    
    All of these helpers can be used in a single `wantErr` field of a test
    table. They can be used for both unit tests and integration tests.
    
    Co-authored-by: Benjamin A. Petersen <ben@benjaminapetersen.me>
    cfryanr and benjaminapetersen committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    c6e4133 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    bd9d6fa View commit details
    Browse the repository at this point in the history