Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve token exchange error messages and error test cases #1264

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Aug 24, 2022

Improve error messages and error test cases for the token endpoint's urn:ietf:params:oauth:grant-type:token-exchange grant type handler, which is used by clients to request cluster-scoped ID tokens.

Release note:

TBD

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1264 (c404651) into main (af7cf67) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   79.72%   79.72%           
=======================================
  Files         144      144           
  Lines       10522    10522           
=======================================
  Hits         8389     8389           
  Misses       1853     1853           
  Partials      280      280           
Impacted Files Coverage Δ
internal/oidc/token_exchange.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cfryanr cfryanr merged commit 736b385 into main Aug 25, 2022
@cfryanr cfryanr deleted the access_token_validation branch August 25, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants