Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC client crd #1185

Merged
merged 4 commits into from
Jun 6, 2022
Merged

OIDC client crd #1185

merged 4 commits into from
Jun 6, 2022

Conversation

margocrawf
Copy link
Contributor

Release note:

@margocrawf
Add CRD for OIDCClient
cd47ba5 
Signed-off-by: Margo Crawford <margaretc@vmware.com>
@margocrawf
Fix some disallowed kubebuilder annotations, fix kube api discovery test
ca3da0b 
Signed-off-by: Margo Crawford <margaretc@vmware.com>
@codecov
Copy link

codecov bot commented Jun 6, 2022 •
edited
Loading

Codecov Report

Merging #1185 (0dec2ee) into dynamic_clients (30d09b2) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           dynamic_clients    #1185   +/-   ##
================================================
  Coverage            79.73%   79.73%           
================================================
  Files                  144      144           
  Lines                10507    10507           
================================================
  Hits                  8378     8378           
  Misses                1850     1850           
  Partials               279      279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d09b2...0dec2ee. Read the comment docs.

enj
enj suggested changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@enj enj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos.

apis/supervisor/oauth/v1alpha1/types_oidcclient.go.tmpl Outdated Show resolved Hide resolved
apis/supervisor/oauth/v1alpha1/types_oidcclient.go.tmpl Outdated Show resolved Hide resolved
@margocrawf
Fix typo in oidcclient spec and status descriptions
3cacb5b 
Signed-off-by: Margo Crawford <margaretc@vmware.com>
@margocrawf
Add enum validation for scopes and grant types
0dec2ee 
Signed-off-by: Margo Crawford <margaretc@vmware.com>
@margocrawf margocrawf enabled auto-merge June 6, 2022 21:03
@margocrawf margocrawf disabled auto-merge June 6, 2022 21:15
@margocrawf margocrawf merged commit e5a96e3 into dynamic_clients Jun 6, 2022
@margocrawf margocrawf deleted the oidc_client_crd branch June 6, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enj enj enj approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@margocrawf @enj @vmwclabot