Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube codegen versions #1149

Merged
merged 1 commit into from
May 2, 2022
Merged

Update kube codegen versions #1149

merged 1 commit into from
May 2, 2022

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented May 2, 2022

Note that attempting to update 1.18.18 to 1.18.20 didn't work for some reason, so I skipped that one. The code generator didn't like 1.18.20 and it deleted all the generated code. Avoiding 1.18.19 because it is listed as having a regression at https://kubernetes.io/releases/patch-releases/#non-active-branch-history.

Release note:

NONE

Note that attempting to update 1.18.18 to 1.18.20 didn't work for some
reason, so I skipped that one. The code generator didn't like 1.18.20
and it deleted all the generated code. Avoiding 1.18.19 because it is
listed as having a regression at
https://kubernetes.io/releases/patch-releases/#non-active-branch-history
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1149 (90e88bb) into main (c74dea6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   79.73%   79.72%   -0.01%     
==========================================
  Files         136      136              
  Lines       10055    10054       -1     
==========================================
- Hits         8017     8016       -1     
  Misses       1767     1767              
  Partials      271      271              
Impacted Files Coverage Δ
internal/upstreamldap/upstreamldap.go 85.67% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee881aa...90e88bb. Read the comment docs.

@cfryanr cfryanr merged commit d6e6101 into main May 2, 2022
@cfryanr cfryanr deleted the update_kube_versions branch May 2, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants