Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape special characters in LDAP DNs when used in search filters #1148

Merged
merged 2 commits into from
May 2, 2022

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented May 2, 2022

Addresses #1147.

Release note:

Bug fix: Fix issue #1147 by escaping special characters in LDAP DNs when used in search filters

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1148 (c74dea6) into main (24b0ddf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   79.70%   79.73%   +0.02%     
==========================================
  Files         136      136              
  Lines       10054    10055       +1     
==========================================
+ Hits         8014     8017       +3     
+ Misses       1769     1767       -2     
  Partials      271      271              
Impacted Files Coverage Δ
internal/upstreamldap/upstreamldap.go 85.71% <100.00%> (+0.03%) ⬆️
...l/localuserauthenticator/localuserauthenticator.go 57.20% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b0ddf...c74dea6. Read the comment docs.

@cfryanr cfryanr merged commit cc1f0b8 into main May 2, 2022
@cfryanr cfryanr deleted the ldap_group_search_escape branch May 2, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants