Switch to go.uber.org/zap for JSON formatted logging

[enj]

Signed-off-by: Monis Khan mok@vmware.com

Release note:

Pinniped server components now log using JSON by default.  The legacy format can be used by setting `log.format` to `text`.  The CLI now has a more friendly output format:

$ pinniped get kubeconfig
Tue, 24 May 2022 11:18:50 EDT  cmd/kubeconfig.go:584  discovered CredentialIssuer  {"name": "concierge-config"}
Tue, 24 May 2022 11:18:50 EDT  cmd/kubeconfig.go:419  discovered Concierge operating in impersonation proxy mode
Tue, 24 May 2022 11:18:50 EDT  cmd/kubeconfig.go:432  discovered Concierge endpoint  {"endpoint": "https://abcd"}
Tue, 24 May 2022 11:18:50 EDT  cmd/kubeconfig.go:447  discovered Concierge certificate authority bundle  {"roots": 1}
Tue, 24 May 2022 11:18:50 EDT  cmd/kubeconfig.go:469  discovered WebhookAuthenticator  {"name": "wa"}

[codecov]

Codecov Report

Merging #1145 (08ff66e) into main (03ccef0) will increase coverage by 0.82%.
The diff coverage is 75.53%.

❗ Current head 08ff66e differs from pull request most recent head 0674215. Consider uploading reports for the commit 0674215 to get more accurate results

@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   79.30%   80.13%   +0.82%     
==========================================
  Files         141      139       -2     
  Lines       10240    10298      +58     
==========================================
+ Hits         8121     8252     +131     
+ Misses       1847     1770      -77     
- Partials      272      276       +4     

Impacted Files	Coverage Δ
cmd/pinniped/cmd/root.go	0.00% <0.00%> (ø)
internal/concierge/server/server.go	25.39% <0.00%> (-0.62%)	⬇️
internal/config/supervisor/types.go	100.00% <ø> (ø)
internal/controller/kubecertagent/kubecertagent.go	91.86% <0.00%> (ø)
internal/controllerlib/controller.go	11.23% <0.00%> (ø)
internal/controllerlib/option.go	23.25% <0.00%> (ø)
internal/controllerlib/recorder.go	0.00% <0.00%> (ø)
internal/kubeclient/copied.go	38.88% <0.00%> (ø)
...l/localuserauthenticator/localuserauthenticator.go	53.53% <0.00%> (-3.67%)	⬇️
internal/upstreamoidc/upstreamoidc.go	88.38% <0.00%> (ø)
... and 36 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ccef0...0674215. Read the comment docs.

[enj]

Things to look at / discuss when reviewing.

[enj]

Summarizing feedback from Jeremy and Anjali:

1. Made json the default
2. Allow using the klog text based format (and ignore the zap console format)
3. Deprecate the option to use the klog text format from the very beginning
4. Before 1.0, and possibly sooner (i.e. if we build some functionality that relies on the zap logger such as redaction), the text based format will be removed (but we will make sure to give enough time for folks to migrate to json)

[netlify]

👷 Deploy request for pinniped pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	ba5b896