oidc: add code challenge supported methods to the discovery doc #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfryanr
requested changes
Apr 18, 2022
There was a problem hiding this comment.
Thanks for the PR @hectorj2f! I added a comment with a couple of suggestions.
hectorj2f
force-pushed
the
add_code_challenge_method_support
branch
from
367bae1
to
8cec382
Compare
Signed-off-by: hectorj2f <hectorf@vmware.com>
hectorj2f
force-pushed
the
add_code_challenge_method_support
branch
from
8cec382
to
a3f7afa
Compare
Codecov Report
@@ Coverage Diff @@
## main #1127 +/- ##
=======================================
Coverage 79.71% 79.72%
=======================================
Files 136 136
Lines 10059 10060 +1
=======================================
+ Hits 8019 8020 +1
Misses 1768 1768
Partials 272 272
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hectorj2f hectorf@vmware.com
This PR includes the
code_challenge_methods_supportedkey, as specified by https://datatracker.ietf.org/doc/html/rfc8414#section-2. If this key is omitted in the document, that'll mean the authorization server does not support PKCE. However the Supervisor does actually support and require PKCE, therefore we should add that key in the discovery document.Fixes #1107
Release note: