Add group change warning test for Active Directory #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margocrawf
force-pushed
the
active-directory-group-change-warning
branch
from
a54d3e0
to
de98d0c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1043 +/- ##
==========================================
+ Coverage 79.36% 79.38% +0.02%
==========================================
Files 133 133
Lines 9992 9992
==========================================
+ Hits 7930 7932 +2
+ Misses 1789 1788 -1
+ Partials 273 272 -1
Continue to review full report at Codecov.
|
enj
approved these changes
Mar 2, 2022
| requireKubectlGetNamespaceOutput(t, env, string(kubectlPtyOutputBytes2)) | ||
| } | ||
| // the output should include a warning that the groups have changed. | ||
| require.Contains(t, string(kubectlPtyOutputBytes2), fmt.Sprintf("User %q has been added to the following groups: %q", sAMAccountName, []string{groupName + "@" + env.SupervisorUpstreamActiveDirectory.Domain})) |
There was a problem hiding this comment.
Suggested change
| require.Contains(t, string(kubectlPtyOutputBytes2), fmt.Sprintf("User %q has been added to the following groups: %q", sAMAccountName, []string{groupName + "@" + env.SupervisorUpstreamActiveDirectory.Domain})) | |
| require.Contains(t, string(kubectlPtyOutputBytes2), fmt.Sprintf(`%sWarning:%s User %q has been added to the following groups: %q`+"\r\n", yellowColor, resetColor, sAMAccountName, []string{groupName + "@" + env.SupervisorUpstreamActiveDirectory.Domain})) |
There was a problem hiding this comment.
I'll wait until #1042 merges, then rebase off of main so I can use the same color variables.
margocrawf
force-pushed
the
active-directory-group-change-warning
branch
from
de98d0c
to
0160045
Compare
Also refactor some of the AD test helper functions Signed-off-by: Margo Crawford <margaretc@vmware.com>
margocrawf
force-pushed
the
active-directory-group-change-warning
branch
from
0160045
to
f6ad5d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor some of the AD test helper functions into their own file for easier sharing.
This is just a test change that adds a more "real world" test of our group refresh functionality. It actually changes the groups in Active Directory, rather than editing the groups in storage in order to make the supervisor think that the groups have changed when we get different ones back upon refresh.
Signed-off-by: Margo Crawford margaretc@vmware.com
Release note: