Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated code for Kube 1.21, 1.22, and 1.23 #1040

Merged
merged 4 commits into from
Mar 1, 2022
Merged

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Mar 1, 2022

Add generated code for Kube 1.21, 1.22, and 1.23

Also:

  • Make our code generator script work with Go 1.17
  • Make our update.sh script work on linux
  • Update the patch versions of the old Kube versions that we were using to generate code (see kube-versions.txt)
  • Use our container images from ghcr instead of projects.registry.vmware.com for codegen purposes
  • Make it easier to debug in the future by passing "-v" to the Kube codegen scripts
  • Updated copyright years to make commit checks pass
  • Use Go 1.17 to generate the code for all Kube versions... Go version is changed inside the container image used by these scripts, and resulting generated code is included in this PR

Release note:

NONE

Also:
- Make our code generator script work with Go 1.17
- Make our update.sh script work on linux
- Update the patch versions of the old Kube versions that we were using
  to generate code (see kube-versions.txt)
- Use our container images from ghcr instead of
  projects.registry.vmware.com for codegen purposes
- Make it easier to debug in the future by passing "-v" to the Kube
  codegen scripts
- Updated copyright years to make commit checks pass
@cfryanr cfryanr marked this pull request as draft March 1, 2022 02:02
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1040 (58f790c) into main (0c866a6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1040   +/-   ##
=======================================
  Coverage   79.38%   79.38%           
=======================================
  Files         133      133           
  Lines        9972     9972           
=======================================
  Hits         7916     7916           
  Misses       1786     1786           
  Partials      270      270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c866a6...58f790c. Read the comment docs.

hack/lib/update-codegen.sh Outdated Show resolved Hide resolved
@cfryanr cfryanr changed the title WIP: Add generated code for Kube 1.21, 1.22, and 1.23 Add generated code for Kube 1.21, 1.22, and 1.23 Mar 1, 2022
@cfryanr cfryanr marked this pull request as ready for review March 1, 2022 18:42
@enj enj enabled auto-merge March 1, 2022 18:49
@cfryanr cfryanr disabled auto-merge March 1, 2022 18:51
@cfryanr cfryanr enabled auto-merge March 1, 2022 18:51
@cfryanr cfryanr merged commit d1f756c into main Mar 1, 2022
@cfryanr cfryanr deleted the codegen-21-22-23 branch March 1, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants