Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI requires HTTPS OIDC issuer, authorize, and token URLS #1013

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Feb 16, 2022

This PR is to address #1012.

Release note:

CLI returns an error for non-HTTPS `--issuer` URL, and for non-HTTPS auto-discovered OIDC authorization and token endpoints from that issuer.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1013 (7946731) into main (cc50fc9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   79.37%   79.36%   -0.02%     
==========================================
  Files         133      133              
  Lines        9931     9944      +13     
==========================================
+ Hits         7883     7892       +9     
- Misses       1784     1786       +2     
- Partials      264      266       +2     
Impacted Files Coverage Δ
pkg/oidcclient/login.go 89.76% <100.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc50fc9...7946731. Read the comment docs.

@cfryanr cfryanr merged commit eaa3e9f into main Feb 16, 2022
@cfryanr cfryanr deleted the cli_require_https_issuers branch February 16, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants