Skip to content

Commit

Permalink
Update comments for testing
Browse files Browse the repository at this point in the history
  • Loading branch information
joshuatcasey committed Aug 27, 2024
1 parent 9b3bcca commit b78e2c7
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ func TestImpersonatorConfigControllerSync(t *testing.T) {
})
r.NoError(err)

// Return a func that starts a fake server when called, and shuts down the fake server when stopCh is closed.
// Return a func that starts a fake server when called, and shuts down the fake server when ctx is cancelled.
// This fake server is enough like the real impersonation proxy server for this unit test because it
// uses the supplied providers to serve TLS. The goal of this unit test is to make sure that the server
// was started/stopped/configured correctly, not to test the actual impersonation behavior.
Expand Down Expand Up @@ -404,7 +404,7 @@ func TestImpersonatorConfigControllerSync(t *testing.T) {
}()

if testHTTPServerInterruptCh == nil {
// Wait in the foreground for the stopCh to be closed, and kill the server when that happens.
// Wait in the foreground for the context to be done, and kill the server when that happens.
// This is similar to the behavior of the real impersonation server.
<-ctx.Done()
} else {
Expand Down

0 comments on commit b78e2c7

Please sign in to comment.