[velero] Add version label to deployment #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattfry
changed the title
…nzu#616) Signed-off-by: Max Xu <xuhuan@live.cn> Signed-off-by: Wyatt Fry <wfry@bridgephase.com>
Signed-off-by: Wyatt Fry <wfry@bridgephase.com>
Signed-off-by: Wyatt Fry <wfry@bridgephase.com>
wyattfry
force-pushed
the
add-version-label-to-deployment
branch
from
9b4853f to
5c7dba2
Compare
|
@aramprice @weseven could i please have one more review? |
|
@wyattfry - you may have tagged the wrong person, I don't have context on this codebase. |
ywk253100
approved these changes
Oct 30, 2024
Ah, sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer:
This PR adds the Kubernetes-recommended label "app.kubernetes.io/version" to the Deployment and its Pods.
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels
The value of the version label:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero])