Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero] allow to specify your custom volume for /scratch folder for restic #314

Merged
merged 3 commits into from
Oct 24, 2021
Merged

[velero] allow to specify your custom volume for /scratch folder for restic #314

merged 3 commits into from
Oct 24, 2021

Conversation

sagor999
Copy link
Contributor

Special notes for your reviewer:

This addresses this issue: #285

This way you can disable default volume and instead provide your own via extraVolumes and extraVolumeMounts

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sagor999.
One comment to enhance the wording/help message.

charts/velero/values.yaml Outdated Show resolved Hide resolved
@jenting jenting linked an issue Oct 13, 2021 that may be closed by this pull request
@jenting jenting added the velero label Oct 13, 2021
@sagor999
Copy link
Contributor Author

@jenting done. thank you.

@jenting
Copy link
Collaborator

jenting commented Oct 14, 2021

@sagor999 would you mind bumping the chart version to 2.25.0? Because I think it's a feature and should bump the minor version, thx.

@sagor999
Copy link
Contributor Author

@jenting not a problem. version bumped.

@jenting
Copy link
Collaborator

jenting commented Oct 14, 2021

DCO (sign off-by) also need for all the commits.

@sagor999
Copy link
Contributor Author

@jenting yup, just signed off again. Do you want me to rebase it again since I see it is showing Chart.yaml is conflicting.

@jenting
Copy link
Collaborator

jenting commented Oct 14, 2021

Yes, rebase plz 🙏

sagor999 and others added 3 commits October 13, 2021 18:04
Signed-off-by: Pavel Tumik <18602811+sagor999@users.noreply.github.com>
Co-authored-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: Pavel Tumik <18602811+sagor999@users.noreply.github.com>
Signed-off-by: Pavel Tumik <18602811+sagor999@users.noreply.github.com>
@sagor999
Copy link
Contributor Author

@jenting done.

Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @sagor999

@ywk253100 ywk253100 merged commit 2cee077 into vmware-tanzu:main Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[velero] allow to specify volume for restic cache
3 participants