-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[velero] allow to specify your custom volume for /scratch folder for restic #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sagor999.
One comment to enhance the wording/help message.
@jenting done. thank you. |
@sagor999 would you mind bumping the chart version to 2.25.0? Because I think it's a feature and should bump the minor version, thx. |
@jenting not a problem. version bumped. |
DCO (sign off-by) also need for all the commits. |
@jenting yup, just signed off again. Do you want me to rebase it again since I see it is showing Chart.yaml is conflicting. |
Yes, rebase plz 🙏 |
Signed-off-by: Pavel Tumik <18602811+sagor999@users.noreply.github.com>
Co-authored-by: JenTing Hsiao <jenting.hsiao@suse.com> Signed-off-by: Pavel Tumik <18602811+sagor999@users.noreply.github.com>
Signed-off-by: Pavel Tumik <18602811+sagor999@users.noreply.github.com>
@jenting done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @sagor999
Special notes for your reviewer:
This addresses this issue: #285
This way you can disable default volume and instead provide your own via
extraVolumes
andextraVolumeMounts
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero]
)