Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velero] deployment.yaml: add --disable-controllers argument #244

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

tobiasgiese
Copy link
Contributor

Special notes for your reviewer:

To allow the usage of the velero server parameter --disable-controllers we need to add a new helm argument.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

Tobias Giese tobias.giese@daimler.com, Daimler TSS GmbH, legal info/Impressum

jenting
jenting previously approved these changes Apr 13, 2021
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@jenting jenting added enhancement New feature or request velero labels Apr 13, 2021
@jenting
Copy link
Collaborator

jenting commented Apr 14, 2021

@tobiasgiese, would you mind to rebase to the current main branch and bump the chart version again? thank you.

Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
@tobiasgiese
Copy link
Contributor Author

tobiasgiese commented Apr 14, 2021

@tobiasgiese, would you mind to rebase to the current main branch and bump the chart version again? thank you.

Done. I think the Chart version 2.17.0 is correct? Or do I have to increase the patch version?

Edit: clarified by the linter :)

Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
Copy link
Collaborator

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again ^^

@jenting
Copy link
Collaborator

jenting commented Apr 14, 2021

@cpanato @carlisia PTAL 🙇

@jenting jenting merged commit 4a0db1b into vmware-tanzu:main Apr 14, 2021
@tobiasgiese tobiasgiese deleted the disable-controllers-arg branch April 14, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request velero
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants