Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Fix missing go sum entries and fix go linting errors #960

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Fix missing go sum entries and fix go linting errors #960

merged 2 commits into from
Jul 8, 2021

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Jul 7, 2021

What this PR does / why we need it

This fixes some broken linting errors ontop of main. We were missing the go.sum entries for the hack/packages/generate-pacakge-repository.go package. This PR adds those entries and fixes the subsequent linting errors associated with that file.

Which issue(s) this PR fixes

N/a - fixes broken CI lint checker on main

Describe testing done for PR

$ go mod download && go mod tidy
$ make check
$ make build

Special notes for your reviewer

N/a

Does this PR introduce a user-facing change?

N/a

@jpmcb jpmcb requested a review from seemiller July 7, 2021 14:31
@dvonthenen
Copy link
Contributor

LGTM!

@jpmcb jpmcb merged commit bfbf386 into main Jul 8, 2021
@jpmcb jpmcb deleted the fix-gomod-linting branch July 8, 2021 15:54
@jpmcb jpmcb mentioned this pull request Jul 19, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvonthenen dvonthenen dvonthenen approved these changes

@seemiller seemiller Awaiting requested review from seemiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpmcb @dvonthenen