This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Enable check for presence of carvel toolset #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need a rebase of this after the code-pocalypse |
The packaging make targets depend on the carvel tools to be present. This enables the check to make sure they are there before running some of the targets that attempt to use them. Signed-off-by: Sean McGinnis <smcginnis@vmware.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The packaging make targets depend on the carvel tools to be present.
This enables the check to make sure they are there before running some
of the targets that attempt to use them.
Which issue(s) this PR fixes
Fixes: #430
Describe testing done for PR
On Linux and Mac hosts, without carvel tools installed, run
make check-carveland verifyit gives an appropriate error.
Special notes for your reviewer
Does this PR introduce a user-facing change?