-
Notifications
You must be signed in to change notification settings - Fork 308
Conversation
52ef3b6
to
4583825
Compare
So my first take on this is to introduce an "environment" file, such as @data/values
---
repo:
#! The name of the Package Repository
name: tce-alpha.tanzu.vmware
#! The URL for the repo image
url: projects.registry.vmware.com/tce/main:alpha
cert_manager:
metadata:
name: cert-manager.1.1.0-vmware-alpha
spec:
version: 1.1.0-vmware-alpha
image: projects.registry.vmware.com/tce/cert-manager-package:alpha You would use ytt --ignore-unknown-comments -f addons/repos/main.yaml -f addons/repos/config/alpha.yaml -f addons/repos/config/overlays -f addons/repos/main/packages |
@seemiller Looks great! I'm wondering about the value of The This would make it easy for users to look in one location for the declaration of our repos. "Overrides" like Let me know your thoughts on this. Some notes:
|
4583825
to
81b775d
Compare
77b5966
to
c5e3c39
Compare
cee458a
to
ff72df9
Compare
@joshrosso @stmcginnis I've updated some things on this branch. Y'all wanna take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments for you @seemiller
953cc7b
to
57cd23d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seemiller let's not introduce addons/repos/stages
with a .gitkeep
file. Instead, any relevant make target should create this directory and we should add it to the main .gitignore
.
0225890
to
966b4e2
Compare
Co-authored-by: joshrosso <rossoj@vmware.com>
Co-authored-by: joshrosso <rossoj@vmware.com>
966b4e2
to
0cc9e1e
Compare
* Reset all packages back to 0.3.0 versions (except for knative-serving, which had a PR to update it) * Ensure all version numbers were correct * renamed fluentbit to fluent-bit for consistency with other references * All pacakges are now push to the repo as imgpkgBundles * "stable" channel updated with SHAs to new imgpkgBundles Signed-off-by: Nicholas Seemiller <nseemiller@vmware.com>
What this PR does / why we need it:
We are currently using a single repo,
main
, for our packages. We need to provide our users with a stable repository of packages while still being able to further develop TCE. This change will introduce non-main repos. Think of these asalpha
orbeta
repos where engineers can make changes to packages and continue development of new features without impacting existing users/clusters.Which issue(s) this PR fixes:
Fixes #385
Describe testing done for PR:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: