This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Fail install if sudo access fails #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone installing TCE either does not have sudo access, or enters the wrong password, it is currently ignored and the script continues on but does not actually complete the install. This adds a check on the sudo attempt to make sure it is successful. If not, it gives an error and exits will a failure return code. Signed-off-by: Sean McGinnis <smcginnis@vmware.com>
github-actions
bot
added
the
owner/release-eng
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
If someone installing TCE either does not have sudo access, or enters
the wrong password, it is currently ignored and the script continues on
but does not actually complete the install.
This adds a check on the sudo attempt to make sure it is successful. If
not, it gives an error and exits will a failure return code.
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #1647
Describe testing done for PR
Local test scripts to attempt to sudo and verify exit code if unable to do so.
Special notes for your reviewer