-
Notifications
You must be signed in to change notification settings - Fork 347
feat: add templated .gitlab-ci.yml
method
#675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
.gitlab-ci.yml
file to enable a G….gitlab-ci.yml
method
@rcroft-work Can you amend and sign the commit bb913bf? It's required by the project. This should do the trick: git commit --amend -s bb913bf0a62e365e3bba405e8c60fb4d33a5e7f2
git push --force |
Marking as draft until commit bb913bf is signed off. |
bb913bf
to
fab2c2d
Compare
…Lab CI/CD pipeline to build the Packer templates This change: - adds new `build-ci.tmpl` that can be used to crete/update `.gitlab-ci.yml` file - adds example `.gitlab.yml` file - adds small section to README.md describing how to use `build-ci.tmpl` that can be used to crete/update `.gitlab-ci.yml` file
fab2c2d
to
8a7e184
Compare
Okay, rebased, signed the commit, and marked as ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Updated `CHANGELOG.md`. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary of Pull Request
Add templated way of generating a
.gitlab-ci.yml
file to enable a GitLab CI/CD pipeline to build the Packer templatesThis change:
build-ci.tmpl
that can be used to crete/update.gitlab-ci.yml
file.gitlab.yml
file.README.md
describing how to usebuild-ci.tmpl
that can be used to create/update.gitlab-ci.yml
file.Type of Pull Request
type/bug
type/feature
ortype/enhancement
type/docs
type/refactor
type/chore
Please describe:
Related to Existing Issues
Closes #674
Test and Documentation Coverage
Breaking Changes?