Skip to content

feat: add templated .gitlab-ci.yml method #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

rcroft-work
Copy link
Contributor

@rcroft-work rcroft-work commented Sep 20, 2023

Summary of Pull Request

Add templated way of generating a .gitlab-ci.yml file to enable a GitLab CI/CD pipeline to build the Packer templates

This change:

  • Adds new build-ci.tmpl that can be used to crete/update .gitlab-ci.yml file
  • Adds example .gitlab.yml file.
  • Adds section to README.md describing how to use build-ci.tmpl that can be used to create/update .gitlab-ci.yml file.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #674

Test and Documentation Coverage

  • Tests have been completed in private GitLab instance
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@rcroft-work rcroft-work requested a review from a team as a code owner September 20, 2023 08:26
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Sep 20, 2023
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam added this to the .Next milestone Sep 20, 2023
@tenthirtyam tenthirtyam changed the title Add templated way of generating a .gitlab-ci.yml file to enable a G… feat: add templated .gitlab-ci.yml method Sep 20, 2023
@tenthirtyam
Copy link
Contributor

@rcroft-work Can you amend and sign the commit bb913bf? It's required by the project.

This should do the trick:

git commit --amend -s bb913bf0a62e365e3bba405e8c60fb4d33a5e7f2
git push --force

@tenthirtyam tenthirtyam marked this pull request as draft September 20, 2023 15:53
@tenthirtyam
Copy link
Contributor

Marking as draft until commit bb913bf is signed off.

@tenthirtyam tenthirtyam marked this pull request as ready for review September 20, 2023 22:13
@tenthirtyam tenthirtyam marked this pull request as draft September 20, 2023 22:13
…Lab CI/CD pipeline to build the Packer templates

This change:

- adds new `build-ci.tmpl` that can be used to crete/update `.gitlab-ci.yml` file
- adds example `.gitlab.yml` file
- adds small section to README.md describing how to use `build-ci.tmpl` that can be used to crete/update `.gitlab-ci.yml` file
@rcroft-work rcroft-work marked this pull request as ready for review September 21, 2023 00:22
@rcroft-work
Copy link
Contributor Author

Okay, rebased, signed the commit, and marked as ready for review.

tenthirtyam
tenthirtyam previously approved these changes Sep 21, 2023
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Updated `CHANGELOG.md`.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam merged commit f509cf3 into vmware-samples:develop Sep 21, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required status/awaitng-response Awaiting Response status/planned Planned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Packer GitLab CI/CD pipelines
3 participants