feat: add support for loading WebAssembly components #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
force-pushed
the
module-or-component
branch
3 times, most recently
from
bed0714
to
2885886
Compare
|
Related to #227 |
Angelmmiguel
reviewed
Oct 2, 2023
Angelmmiguel
reviewed
Oct 2, 2023
Angelmmiguel
reviewed
Oct 2, 2023
There was a problem hiding this comment.
This is a huuuuge effort @ereslibre ! Congratulations for such a complete PR. I'm really happy that wws starts supporting components and regular core modules. This PR will open a new set of possibilities for the project 😄.
I added some minor comments, but everything LGTM!
Also, improve the errors returned by the different phases
ereslibre
force-pushed
the
module-or-component
branch
4 times, most recently
from
82b6be1
to
cc3adca
Compare
ereslibre
force-pushed
the
module-or-component
branch
from
cc3adca
to
048a8d3
Compare
ereslibre
force-pushed
the
module-or-component
branch
5 times, most recently
from
7e24b21
to
c55543e
Compare
Angelmmiguel
approved these changes
Oct 3, 2023
Angelmmiguel
reviewed
Oct 3, 2023
ereslibre
force-pushed
the
module-or-component
branch
from
c55543e
to
f8e35d5
Compare
Also, specify how to reproduce the wasi-component-adapter binaries.
ereslibre
force-pushed
the
module-or-component
branch
from
f8e35d5
to
e478b35
Compare
|
We can merge on green then, thanks for the reviews and feedback @Angelmmiguel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for loading WebAssembly modules and components. It also adds components under
examplesand adds them to the e2e test suite.Missing bits: