Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Fix SyncReconciler passing reflect.Type as key to logger #80

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

Samze
Copy link
Contributor

@Samze Samze commented Feb 1, 2021

This causes logging implementations such as Zap to panic

Signed-off-by: Gabriele Cipriano gcipriano@vmware.com

Cheers Sam and @gabrielecipriano

* This causes logging implementations such as Zap to panic.

Signed-off-by: Gabriele Cipriano <gcipriano@vmware.com>
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #80 (6c6ce60) into main (aa9f43e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   64.04%   64.04%           
=======================================
  Files          10       10           
  Lines         648      648           
=======================================
  Hits          415      415           
  Misses        220      220           
  Partials       13       13           
Impacted Files Coverage Δ
reconcilers/reconcilers.go 84.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9f43e...dd40123. Read the comment docs.

@scothis
Copy link
Contributor

scothis commented Feb 1, 2021

Thanks

@scothis scothis merged commit 18139c2 into vmware-labs:main Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants