This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
Allow WithConfig to create dynamic configs #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithConfig#Config is now a function that has access to the context and the current config. A custom config can be created for a specific parent resource. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 62.14% 61.84% -0.30%
==========================================
Files 9 9
Lines 906 912 +6
==========================================
+ Hits 563 564 +1
- Misses 325 329 +4
- Partials 18 19 +1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithConfig#Configis now a function that has access to the context andthe current config. A custom config can be created for a specific parent
resource.
This would be a breaking change to
WithConfig, except that it has not been released yet.Signed-off-by: Scott Andrews andrewssc@vmware.com