This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Error in activity reporter not visible, need to scroll to the top #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please create a new example under activity reporter that shows this behavior |
juanmendes
suggested changes
Dec 5, 2023
projects/components/src/common/activity-reporter/banner-activity-reporter.component.ts
Outdated
Show resolved
Hide resolved
Juliana216
force-pushed
the
topic/jsica/COR-12499
branch
from
b09499e
to
3bdbbdb
Compare
added 2 commits
December 5, 2023 11:58
Add a scrollIntoView method for the vcd-banner-activity-reporter. This increases the visibility of success and error messages by scrolling the activity reporter banner into view. Testing Done: - Added examples to have a page where activity banner is not visible so the scrollIntoView method is used. - Observed that the scrolling to the activity banner was successful. Signed-off-by: Juliana Sica <juliana.sica@broadcom.com>
Add a scrollIntoView method for the vcd-banner-activity-reporter. This increases the visibility of success and error messages by scrolling the activity reporter banner into view. Testing Done: - Added examples to have a page where activity banner is not visible so the scrollIntoView method is used. - Observed that the scrolling to the activity banner was successful. Signed-off-by: Juliana Sica <juliana.sica@broadcom.com>
Juliana216
force-pushed
the
topic/jsica/COR-12499
branch
from
3bdbbdb
to
67b6059
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: Add a scrollToMessage method for the vcd-banner-activity-reporter. This increases the visibility of success and error messages by having them in the view of the user.
Testing Done:
Screen.Recording.2023-12-04.at.12.17.32.PM.mov
COR-12499
https://bugzilla.eng.vmware.com/show_bug.cgi?id=2858757