Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fix VCD datagrid dropdown actions column width #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpresiana
Copy link
Contributor

@dpresiana dpresiana commented Jun 6, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Examples have been added / updated (for bug fixes / features)
  • Changelog has been updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Example website changes
  • Version bump
  • Other... Please describe:

What does this change do?

Minor fix for datagrid dropdown actions column width in some corner cases when datagrid is empty or the columns are rendered before the grid is populated with data

What manual testing did you do?

Test in the VCD project (no way to test it in the components examples since the issue is a corner case)

Empty state test case steps:

  1. Go to Provider Gateway details in the Provider portal with no BGP Community Lists added (should see the empty state)
  2. Verify that the column width is normal (38px)
Before After
Screenshot 2023-06-06 at 19 06 11 Screenshot 2023-06-06 at 19 05 54

Columns rendered before data case steps:

  1. Go to Content hub in the Tenant portal
  2. Go to Content -> Application Images (this should be opened by default)
  3. Switch to see grid view
  4. Verify that the column width is normal (38px)
Before After
https://github.com/vmware/vmware-cloud-director-ui-components/assets/77797592/796c3686-77c0-4ca2-a246-f5957c526459 https://github.com/vmware/vmware-cloud-director-ui-components/assets/77797592/08c42861-989e-4090-85d6-b354d555806f

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Bug Number: https://jira.eng.vmware.com/browse/VDU-8198

@vmwclabot
Copy link

@dpresiana, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@dpresiana dpresiana force-pushed the bug/dpresiana/VDU-8198-dropdown-actions-column-width branch from 42514fb to 806e550 Compare June 6, 2023 16:21
@vmwclabot
Copy link

@dpresiana, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@dpresiana dpresiana force-pushed the bug/dpresiana/VDU-8198-dropdown-actions-column-width branch from 806e550 to fb6c657 Compare June 6, 2023 16:22
When datagrid is empty or the columns are rendered before the grid is populated with data the width of the dropdown actions column is wider than expected

Testing Done:
Test in the VCD project (no way to test it in the components examples since the issue is a corner case)

Bug Number: https://jira.eng.vmware.com/browse/VDU-8198

Signed-off-by: Presiana Dimitrova <dpresiana@vmware.com>
@dpresiana dpresiana force-pushed the bug/dpresiana/VDU-8198-dropdown-actions-column-width branch from fb6c657 to 95c379e Compare June 27, 2023 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants