This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix: Schedule bus callbacks in autogen code through NgZone #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooskim
force-pushed
the
topic/kjosh/ngzone-autogen-fix
branch
from
e305758
to
2f837dc
Compare
Signed-off-by: Josh Kim <kjosh@vmware.com>
jooskim
force-pushed
the
topic/kjosh/ngzone-autogen-fix
branch
from
2f837dc
to
02d0069
Compare
|
Force-merging since Dave is out on PTO given the important of the fix being available promptly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that was identified while testing 1.3.2 locally on VMware Cloud UI workflows. The autogenerated code utilizes autogenerated bus channels, from and to which messages are transmitted outside of Angular Zone based on the changes made in the previous release. At some point after calling an API using the autogenerated service adapter method, results are returned back as a callback which is expected to be running in Angular Zone.
However, the API success callback was still running outside of Angular Zone, so any tasks that would schedule a macro/micro task were running side-by-side with Angular's change detection system instead of being scheduled properly next to the earlier tasks in the queue, ultimately causing the unstable UI state.
Signed-off-by: Josh Kim kjosh@vmware.com