This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update plugin and Yeoman generator to 0.21.0, add more recent components from Octant #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM Version updates:
plugin/package.json
updated from0.2.2
to0.21.0
yeoman-generator/package.json
updated from0.2.2
to0.21.0
There are issues with Yeoman pulling outdated code from NPM, leading to newly-created plugins not installing (see #20), so updating the version should result in future Yeoman generations to use correct code. Additionally, this PR adds more components to the plugin, generated by command in the main Octant repo (reference).
If/when this PR is merged in, the following commands might need to be run to publish the revised package versions to NPM:
npm publish
inside./plugin
npm publish
inside./yeoman-generator
Potential testing steps
After publishing,
npm update -g @project-octant/generator-octant-plugin
to update the generator globallyyo @project-octant/octant-plugin
to generate a new plugin with Yeomannpm run plugin:install
and verify that the project compiles on the first tryOctant component update
As described above, the
go run ./cmd/ts-component-gen/main.go
was run to programmatically update the TS components in theplugin/components
directory.Notes
Almost all components generated successfully, with the exception ofExpandableRowDetail
(source file); attempting to generate it threw the following error:Since generating this component would require changes to the main Octant repo, I left it out of the PR; if we decide that this component is necessary, maybe we could create another PR that addressesExpandableRowDetail
specifically. My main concern when making these changes was to update the plugin and the Yeoman generator so that users can build functional plugins without needing to edit pre-generated code.This error has been resolved, please see the upstream PR here.