Review unresolved PR comments status for upstream PR #3008 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for managing GitHub Enterprise Teams (enterprise-level teams): Resources: - github_enterprise_team: create/update/delete enterprise teams - github_enterprise_team_membership: manage team members - github_enterprise_team_organizations: assign teams to organizations Data sources: - github_enterprise_team: lookup by slug or ID - github_enterprise_teams: list all enterprise teams - github_enterprise_team_membership: check user membership - github_enterprise_team_organizations: list assigned orgs Note: These endpoints require GitHub Enterprise Cloud with a classic PAT that has enterprise admin permissions.
- Add ValidateDiagFunc to required schema fields for early validation in plan phase - Add validation import to resource_github_enterprise_team_membership - This allows users to get validation errors during plan instead of apply
- Add Description field to github_enterprise_team resource schema - Add Description field to github_enterprise_team_membership resource schema - Descriptions match the documentation pages and will be used for generated docs
- try EnterpriseService.GetTeam via reflection to stay forward-compatible with upcoming SDK release - keep REST fallback when SDK method is missing - no behavior change; builds with current v67 while ready for v81
- move required field emptiness checks into ValidateDiagFunc - remove redundant runtime empty checks in Read - keep behavior unchanged, but surface errors during plan
…rg data sources/resources - add top-level Description to enterprise team org data source and resource - add ValidateDiagFunc to required fields and drop runtime empty checks - add Description and validation to enterprise teams listing data source
- Replace custom API implementations with go-github v81 SDK functions - Use EnterpriseService methods: CreateTeam, GetTeam, UpdateTeam, DeleteTeam, ListTeams, ListAssignments, AddMultipleAssignments, RemoveMultipleAssignments, GetTeamMembership, AddTeamMember, RemoveTeamMember - Change ID separator from '/' to ':' to reuse existing util.go functions - Move single-use helper functions to their respective files - Simplify util_enterprise_teams.go to only findEnterpriseTeamByID - Update test files to use testAccConf patterns
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Add top-level Description field to data source - Remove redundant ConflictsWith from team_id (ExactlyOneOf on slug is sufficient)
…ality Address code review feedback from @deiga and improve enterprise team resources. ## Changes ### Schema improvements - Separate enterprise_team field into team_slug and team_id with ExactlyOneOf validation for membership and organizations resources - Align data source naming with resources (enterprise_team → team_slug) - Fix ExactlyOneOf in data_source_github_enterprise_team (must include both fields) - Add validation for slug field in data source ### Code quality - Remove Read-after-Create/Update pattern, set computed fields directly from API response - Remove unused findEnterpriseTeamBySlugOrID function - Move shared helpers to util_enterprise_teams.go - Use "/" as ID separator instead of ":" (team slugs contain ":") - Handle errors properly in Import function ### Bug fixes - Add 404 handling in Delete for membership and organizations resources - Fix group_id clearing (now sends empty string to API) - Preserve team_id in state when user configures via team_id - Fix Read drift when user configures team_id instead of team_slug ### Testing - Eliminate redundant testCase wrapper pattern in tests - Add MinItems validation test for organization_slugs - All 8 acceptance tests passing ### Documentation - Update docs for new team_slug/team_id schema
Co-authored-by: vmvarela <11040851+vmvarela@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review unresolved PR comments status
Review unresolved PR comments status for upstream PR #3008
Jan 16, 2026
vmvarela
force-pushed
the
enterprise-teams
branch
2 times, most recently
from
1bb8034 to
4d9a880
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Report Contents
File:
PR_3008_UNRESOLVED_COMMENTS_STATUS.mdSections:
The report enables quick assessment of PR readiness and provides clear next steps for the author.
Original prompt
Created from VS Code via the GitHub Pull Request extension.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.