Prevent exponential backoff delay from overflowing#199
Open
skateinmars wants to merge 1 commit intovmihailenco:v3from
Open
Prevent exponential backoff delay from overflowing#199skateinmars wants to merge 1 commit intovmihailenco:v3from
skateinmars wants to merge 1 commit intovmihailenco:v3from
Conversation
8f03fe4 to
2ea58e8
Compare
2ea58e8 to
fdf44a4
Compare
Collaborator
|
@skateinmars I think you can move the code from https://go.dev/play/p/V2tno9piKlk to a test https://github.com/vmihailenco/taskq/blob/v3/consumer_test.go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the bit shifting used in the exponential backoff computation, an overflow can happen given some specific values for min/max backoff.
Here is a snippet to show the current and fixed behavior: https://go.dev/play/p/V2tno9piKly
This PR fixes it without trying to change the "normal" behavior by simply using the max backoff value when an overflow happens.