fix: handling of nil passed as an arg to a typed interface parameter …#161
Open
shaunco wants to merge 3 commits intovmihailenco:v3from
Open
fix: handling of nil passed as an arg to a typed interface parameter …#161shaunco wants to merge 3 commits intovmihailenco:v3from
shaunco wants to merge 3 commits intovmihailenco:v3from
Conversation
Owner
|
Please add a test. |
Contributor
Author
|
Turns out the code path that I fixed was only used for messages that are never serialized with msgpack (such as memqueue). In writing the new unit test, I'm having very strange issues on the Redis side where msgpack is used: msgpack seems to encode/decode nil interfaces just fine, but when I pass in an actual object as an interface the decode seems to think the interface object is a I don't know msgpack well enough to have a solution yet, but am still digging. |
Contributor
Author
|
Ok, ignore the above... After reading vmihailenco/msgpack#261 , I see my understanding of msgpack was flawed. Since the code path I patched is just for memqueue (where args are not msgpacked), I put the test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for #160