🐛 [Bug] Disconnect after boarding the boat in Ratchet

[Marcelo20XX]

🐛 Bug report

When your char has a pet (either a Warlock or Hunter) and you set the option to unsummon your pet when mounting in "mangosd.conf" and board the boat while mounted you get disconnected from the server

Expected behavior

Board the boat without being disconnected

Steps to reproduce

1. Go to Ratchet
2. Try to board the boat while mounted and having a permanent pet
3. Got disconnected
4. ...
5. Profit

Version & Environment

Client Version:

• 1.12.1.5875

Operating System:

• Win 10

Crashlog

• None

Can confirm this using commit 6012f59 on Ubuntu 24.04. The player looses connection and the server does not respond anymore, had to kill the process manually.

The issue is caused by this lock in GenericTransport::AddPassenger:

core/src/game/Transports/Transport.cpp

Line 206 in 4d34de5

std::lock_guard<std::mutex> lock(m_passengerMutex);

In SetTransport the player is forced to dismount and the pet is re-summoned, which leads to a deadlock when it also calls AddPassenger here:

core/src/game/Objects/Pet.cpp

Line 238 in 4d34de5

owner->GetTransport()->AddPassenger(this);

A solution would be to use std::recursive_mutex, but I don't know if this is the correct way to handle this.