Repository navigation
Uni. ctrl. debugging and coverage - #5
Merged
Merged
Conversation
Member
Author
|
Let's demonstrate that this actually passes with a nonzero control, on the CI, but I've already verified that it should. |
bennbollay
reviewed
Jan 29, 2019
| - if [ "${PYTHON:0:1}" = "3" ]; then pip$PY install dormouse; fi | ||
| - cd ../.. && git clone https://github.com/vm6502q/qrack.git | ||
| - cd qrack && mkdir _build && cd _build && cmake .. && sudo make install && cd ../.. && sudo rm -r qrack && cd ProjectQ-Framework/ProjectQ | ||
| - cd qrack && mkdir _build && cd _build && cmake .. && sudo make install && cd ../.. && sudo rm -r qrack && cd vm6502q/ProjectQ |
Member
There was a problem hiding this comment.
Any way this can be extrapolated into an environment variable or discovered from travis?
Member
Author
There was a problem hiding this comment.
Good question! I am trying to figure that out. It's an immediate priority, and I don't have many more left, for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This debugs and adds coverage for native simulator "uniformly controlled" rotation gates.
The problem was, "uniformly controlled" gates don't handle their control bits by the same mechanism as gates that use the "C()" meta gate.
This will be merged into the PR for upstream consideration. I am aware of no other bugs, at the moment. Once our coverage passes their requirements, this initial integration can be considered finished, from our end, as far as I am aware. Changes will made as necessary or as suggested by the master ProjectQ maintainers.