fix issue camelot-dev#43: close_fds incompatibility on windows platform

vm-asd2015 · Feb 11, 2019 · f5f6de1 · f5f6de1
1 parent bae34cf
commit f5f6de1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/excalibur/executors/celery_executor.py b/excalibur/executors/celery_executor.py
@@ -3,6 +3,7 @@
 import logging
 import traceback
 import subprocess
+import sys
 
 from celery import Celery
 
@@ -28,7 +29,7 @@
 @app.task
 def execute_command(command):
     try:
-        subprocess.check_call(command, stderr=subprocess.STDOUT, close_fds=True)
+        subprocess.check_call(command, stderr=subprocess.STDOUT, close_fds=(sys.platform != 'win32'))
     except Exception as e:
         traceback.print_exc()
 

diff --git a/excalibur/executors/sequential_executor.py b/excalibur/executors/sequential_executor.py
@@ -3,13 +3,14 @@
 import traceback
 import subprocess
 from concurrent.futures import ProcessPoolExecutor
+import sys
 
 from .base_executor import BaseExecutor
 
 
 def execute_command(command):
     try:
-        subprocess.check_call(command, stderr=subprocess.STDOUT, close_fds=True)
+        subprocess.check_call(command, stderr=subprocess.STDOUT, close_fds=(sys.platform != 'win32'))
     except FileNotFoundError:
         # TODO: PyInstaller does not package console_scripts
         # https://github.com/pyinstaller/pyinstaller/issues/305