Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixing: issues reported by lgtm.com #172

Open
Pitterling opened this issue Jan 27, 2019 · 0 comments
Open

Bug fixing: issues reported by lgtm.com #172

Pitterling opened this issue Jan 27, 2019 · 0 comments
Milestone
6.0

Comments

@Pitterling
Copy link
Collaborator

https://lgtm.com/projects/g/vlsi/ksar/alerts/?mode=list
@Pitterling Pitterling added the bug label Jan 27, 2019
@Pitterling Pitterling mentioned this issue Sep 8, 2019
Merged
Pitterling added a commit that referenced this issue Sep 8, 2019
@Pitterling
address some LGTM reported issues and other inspections (#188)
dea8d8b 
* make package privat and remove redundant returns and var initialization

* use parametrized constructor

addresses #172

* LGTM - This check is useless, myfilereader cannot be null here, since new BufferedReader(...) always is non-null.

* LGTM - This FileOutputStream is not always closed on method exit.

* LGTM - The variable 'tmp' is only assigned values of primitive type and is never 'null', but it is declared with the boxed type 'Integer'.
@Pitterling Pitterling added this to the 5.2.4 milestone Sep 8, 2019
@Pitterling Pitterling removed the bug label May 12, 2020
Pitterling added a commit that referenced this issue May 12, 2020
@Pitterling
Merge pull request #206 from Pitterling/fix174_compiler_warnings
00c6eae 
fix #174 compiler warnings + #172 addresses some LGTM alerts
@Pitterling Pitterling modified the milestones: 5.2.4, 6.0 Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
1 participant
@Pitterling