Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] Support bitsandbytes for MiniCPMV #9891

Merged
merged 1 commit into from
Nov 1, 2024
Merged

[Model] Support bitsandbytes for MiniCPMV #9891

merged 1 commit into from
Nov 1, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Oct 31, 2024 •
edited
Loading

Requires #9887

FIX #6932
FIX #7727

Note that the arguments --quantization bitsandbytes --load-format bitsandbytes are required because of the weight -> qweight loading.

Tested with:

vllm serve openbmb/MiniCPM-V-2_6-int4 --trust-remote-code --quantization bitsandbytes --load-format bitsandbytes

and

vllm serve mgoin/MiniCPM-Llama3-V-2_5-int4 --trust-remote-code --quantization bitsandbytes --load-format bitsandbytes

@mgoin
[Model] Support bitsandbytes for MiniCPMV
60aa3dd 
Signed-off-by: mgoin <michael@neuralmagic.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 31, 2024
DarkLight1337
DarkLight1337 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support!

@DarkLight1337 DarkLight1337 merged commit 93a76dd into vllm-project:main Nov 1, 2024
71 checks passed
@DarkLight1337 DarkLight1337 mentioned this pull request Nov 1, 2024
Open
51 tasks
@jeejeelee jeejeelee mentioned this pull request Nov 1, 2024
Closed
1 task
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@mgoin
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
cac4710 
Signed-off-by: mgoin <michael@neuralmagic.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@mgoin
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
6fcde45 
Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Linkun Chen <github+anyscale@lkchen.net>
richardsliu pushed a commit to richardsliu/vllm that referenced this pull request Nov 4, 2024
@mgoin @richardsliu
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
7c07ae3 
Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Richard Liu <ricliu@google.com>
bigPYJ1151 pushed a commit to bigPYJ1151/vllm that referenced this pull request Nov 5, 2024
@mgoin @bigPYJ1151
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
3017e9b 
Signed-off-by: mgoin <michael@neuralmagic.com>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
@mgoin @hissu-hyvarinen
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
e9ac8b9 
Signed-off-by: mgoin <michael@neuralmagic.com>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@mgoin @JC1DA
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
71ee4ef 
Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@mgoin @sumitd2
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
88525b1 
Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@mgoin
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
7c9678c 
Signed-off-by: mgoin <michael@neuralmagic.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@mgoin @mfournioux
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
d2cac9c 
Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@mgoin @tlrmchlsmth
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
3bcbf14 
Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@mgoin
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
739517d 
Signed-off-by: mgoin <michael@neuralmagic.com>
sergeykochetkov pushed a commit to sergeykochetkov/vllm_spec_decoding that referenced this pull request Dec 27, 2024
@mgoin
[Model] Support bitsandbytes for MiniCPMV (vllm-project#9891)
f7cc665 
Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: s.kochetkov <s.m.kochetkov@tcsbank.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Model]: MiniCPM-V-2_6-int4 [Feature Request]: Support INT4 for MiniCPM-Llama3-V-2_5
2 participants
@mgoin @DarkLight1337