Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Add support for H2OVL-Mississippi models #9747

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

cooleel
Copy link

@cooleel cooleel commented Oct 28, 2024

FILL IN THE PR DESCRIPTION HERE

FIX #xxxx (link existing issues this PR will resolve)


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels

Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

  • Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
  • Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
  • Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops. See tests/kernels for examples.
  • When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
  • If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@cooleel cooleel changed the title Add support for H2OVL-Mississippi models [Model] Add support for H2OVL-Mississippi models Oct 28, 2024
@cooleel cooleel force-pushed the h2ovl-mississippi branch 3 times, most recently from 30ba48f to 2dfd320 Compare October 28, 2024 14:44
@cooleel cooleel marked this pull request as ready for review October 28, 2024 16:47
@mergify mergify bot added documentation Improvements or additions to documentation frontend labels Oct 28, 2024
@ywang96 ywang96 self-assigned this Oct 29, 2024
Copy link
Collaborator

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments about twice image processing. Seems that load_image1/load_image2 and dynamic_preprocess1/dynamic_preprocess2 are a little bit duplicated.

vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cooleel! Thank you for making this contribution!

Please take a look at the comments, especially those regarding how we should avoid double image processing calls.

vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
@cooleel
Copy link
Author

cooleel commented Oct 29, 2024

Thanks for the careful review and insightful comments.
I've made several improvements and refactored the code to address the points you raised.
Please take a look, and let me know if further adjustments are needed.

vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
vllm/model_executor/models/h2ovl.py Outdated Show resolved Hide resolved
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
…ant image preprocessing calls

Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
Signed-off-by: Shanshan Wang <shanshan.wang@h2o.ai>
@cooleel
Copy link
Author

cooleel commented Oct 31, 2024

Code was formatted by format.sh. but still failed in yapf. mentioned in #9890

@ywang96
Copy link
Member

ywang96 commented Nov 1, 2024

Code was formatted by format.sh. but still failed in yapf. mentioned in #9890

This is an interesting one - yapf and isort are actually overwriting each other.. going to disable yapf for that import statement.

Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
@cooleel
Copy link
Author

cooleel commented Nov 1, 2024

@ywang96 Thank you for working through the format tests! If you spot any areas in my code that need further adjustment, please feel free to let me know.

@ywang96
Copy link
Member

ywang96 commented Nov 1, 2024

@ywang96 Thank you for working through the format tests! If you spot any areas in my code that need further adjustment, please feel free to let me know.

Thanks! I will give this PR some testing but we should be able to merge this by EoD!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants