Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] comment to avoid future confusion about baichuan #9620

Merged
merged 2 commits into from
Oct 23, 2024
Merged

[misc] comment to avoid future confusion about baichuan #9620

merged 2 commits into from
Oct 23, 2024

Conversation

youkaichao
Copy link
Member

fixes #9619

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
comment to avoid future confusion
489b2f3 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao
typo
605c66d 
Signed-off-by: youkaichao <youkaichao@gmail.com>
@jeejeelee
Copy link
Contributor

I was also confused before. Perhaps adding comments to the model config would make it easier to understand, see: https://huggingface.co/baichuan-inc/Baichuan-7B/blob/5d86e56a58fe4a5b3292cd9bb7468afef6f93eab/config.json#L3 and https://huggingface.co/baichuan-inc/Baichuan2-13B-Chat/blob/c8d877c7ca596d9aeff429d43bff06e288684f45/config.json#L4

@youkaichao
Copy link
Member Author

I was also confused before. Perhaps adding comments to the model config would make it easier to understand, see: huggingface.co/baichuan-inc/Baichuan-7B/blob/5d86e56a58fe4a5b3292cd9bb7468afef6f93eab/config.json#L3 and huggingface.co/baichuan-inc/Baichuan2-13B-Chat/blob/c8d877c7ca596d9aeff429d43bff06e288684f45/config.json#L4

we cannot change their config. it would be better if someone can contact them.

@youkaichao youkaichao merged commit dbdd3b5 into vllm-project:main Oct 23, 2024
20 of 22 checks passed
@youkaichao youkaichao deleted the baichuan branch October 23, 2024 16:14
@jeejeelee
Copy link
Contributor

I was also confused before. Perhaps adding comments to the model config would make it easier to understand, see: huggingface.co/baichuan-inc/Baichuan-7B/blob/5d86e56a58fe4a5b3292cd9bb7468afef6f93eab/config.json#L3 and huggingface.co/baichuan-inc/Baichuan2-13B-Chat/blob/c8d877c7ca596d9aeff429d43bff06e288684f45/config.json#L4

we cannot change their config. it would be better if someone can contact them.

I mean we can add model configuration related comments in this PR

@youkaichao
Copy link
Member Author

I mean we can add model configuration related comments in this PR

where to add it?

Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@youkaichao @Alvant
[misc] comment to avoid future confusion about baichuan (vllm-project…
05e8bd1 
…#9620)

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Alvant <alvasian@yandex.ru>
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
@youkaichao
[misc] comment to avoid future confusion about baichuan (vllm-project…
277d5f6 
…#9620)

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Erkin Sagiroglu <erkin@infra-aipipeline-1-at1-prox-prod-a.ipa.corp.telnyx.com>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@youkaichao @FerdinandZhong
[misc] comment to avoid future confusion about baichuan (vllm-project…
b102232 
…#9620)

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: qishuai <ferdinandzhong@gmail.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@youkaichao @NickLucche
[misc] comment to avoid future confusion about baichuan (vllm-project…
a426ab9 
…#9620)

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@youkaichao @NickLucche
[misc] comment to avoid future confusion about baichuan (vllm-project…
fb45daf 
…#9620)

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Misc]: duplicate BaiChuanForCausalLM
2 participants
@youkaichao @jeejeelee