-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Consolidate cleanup() and refactor offline_inference_with_prefix.py #9510
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be able to hit test_lazy_outlines.py
with a cleanup as well:
vllm/tests/entrypoints/llm/test_lazy_outlines.py
Lines 17 to 34 in ae8b633
llm = LLM(model="facebook/opt-125m", | |
enforce_eager=True, | |
gpu_memory_utilization=0.3) | |
outputs = llm.generate(prompts, sampling_params) | |
for output in outputs: | |
prompt = output.prompt | |
generated_text = output.outputs[0].text | |
print(f"Prompt: {prompt!r}, Generated text: {generated_text!r}") | |
# make sure outlines is not imported | |
assert 'outlines' not in sys.modules | |
# The second LLM needs to request a higher gpu_memory_utilization because | |
# the first LLM has already allocated a full 30% of the gpu memory. | |
llm = LLM(model="facebook/opt-125m", | |
enforce_eager=True, | |
guided_decoding_backend="lm-format-enforcer", | |
gpu_memory_utilization=0.6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the nice cleanup!
ba84e5f
to
1d4a009
Compare
CI failed due to #9424 which is unrelated |
…ix.py (vllm-project#9510) Signed-off-by: charlifu <charlifu@amd.com>
…ix.py (vllm-project#9510) Signed-off-by: Vinay Damodaran <vrdn@hey.com>
…ix.py (vllm-project#9510) Signed-off-by: Alvant <alvasian@yandex.ru>
…ix.py (vllm-project#9510) Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
…ix.py (vllm-project#9510) Signed-off-by: qishuai <ferdinandzhong@gmail.com>
…ix.py (vllm-project#9510) Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
…ix.py (vllm-project#9510) Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
…ix.py (vllm-project#9510) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
When refactoring offline_inference_with_prefix.py due to #9505, I found that
cleanup()
has been implemented many times in contests. This PR consolidates them to a utility function.cc @tlrmchlsmth @DarkLight1337 @youkaichao