-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][CI/Build] Fix CUDA 11.8 Build #9386
[Bugfix][CI/Build] Fix CUDA 11.8 Build #9386
Conversation
…t help perf that much that anyways
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
f98ce3d
to
5a7b00e
Compare
Thanks @LucasWilkinson, is this ready for review? |
Basically just waiting for my docker build tests to finish to confirm the fix, they are slow haha |
Confirmed, this builds (i.e. this PR)
and this fails (i.e. main):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Signed-off-by: Alvant <alvasian@yandex.ru>
Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
Signed-off-by: qishuai <ferdinandzhong@gmail.com>
Dont build 9.0a for scaled_mm_c2x since it's outside of cuda 12.0 guard and won't help perf that much that anyways.
The issue here was that for CUDA 11.8 if we were building for 9.0 we wouldn't build scaled_mm_c3x so we would instead try to build scaled_mm_c2x for all versions, i.e. "7.5;8.0;8.6;8.9;9.0;9.0a", this is incorrect though since 9.0a isn't supported by 11.8. We can just drop 9.0a for scaled_mm_c2x since scaled_mm_c2x won't take advantage of the 9.0a features anyways.
(and fix c3x error message false reporting that there were no compatible arches when on 11.8)