Skip to content

[BugFix] Fix test breakages from transformers 4.45 upgrade #8829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Sep 26, 2024
Merged

[BugFix] Fix test breakages from transformers 4.45 upgrade #8829

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4f53397
[BugFix] Fix test breakages from transformers 4.45 upgrade
njhill Sep 26, 2024
e2ae1bb
Also fix llava OOM from @ywang96
njhill Sep 26, 2024
66c0c19
Fix next failures
njhill Sep 26, 2024
a5b289c
Catch any Exception when attempting to load lora-specific tokenizer
njhill Sep 26, 2024
ce1d477
Change "default" rope scaling type back to "mrope" in HF config
njhill Sep 26, 2024
4eaa8e1
raise gpu mem
Sep 26, 2024
899003b
Merge branch 'main' into transformers-fixes
DarkLight1337 Sep 26, 2024
562f816
Remove unnecessary overwrite
DarkLight1337 Sep 26, 2024
51b9abc
Remove unnecessary version guards
DarkLight1337 Sep 26, 2024
8e7f2b6
Update A100 distributed test with new file location (missed in #7820)
DarkLight1337 Sep 26, 2024
57b7328
Replace legacy `tmpdir` with modern `tmp_path` fixture
DarkLight1337 Sep 26, 2024
0ebd4fb
Reduce max_model_len in LLaVA-OneVision test to avoid OOM
DarkLight1337 Sep 26, 2024
4a924c8
Patch `ChatGLMTokenizer._pad`
DarkLight1337 Sep 26, 2024
0c30e87
Run OOT test in a clean process to solve OOM in AMD
DarkLight1337 Sep 26, 2024
9f2fac8
Fix insufficient `max_model_len`
DarkLight1337 Sep 26, 2024
2b6948c
Fix wrong test being updated
DarkLight1337 Sep 26, 2024
45e2b54
Cleanup
DarkLight1337 Sep 26, 2024
f0584fa
raise mem
Sep 26, 2024
27b96c1
format
Sep 26, 2024
cd105be
Merge remote-tracking branch 'upstream/main' into transformers-fixes
Sep 26, 2024
315ff90
remove comment
Sep 26, 2024
8fdad1c
skip test
Sep 26, 2024
6decd70
revert soft fail
Sep 26, 2024
59bc78d
Update tokenizer patch
DarkLight1337 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix insufficient max_model_len
  • Loading branch information
@DarkLight1337
DarkLight1337 committed Sep 26, 2024
commit 9f2fac8864fd15ce92eb6c94deb84fe68050bb7c
2 changes: 1 addition & 1 deletion tests/models/decoder_only/vision_language/test_llava_next.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def _run_test(
# max_model_len should be greater than image_feature_size
with vllm_runner(model,
dtype=dtype,
max_model_len=10240,
max_model_len=16384,
tensor_parallel_size=tensor_parallel_size,
distributed_executor_backend=distributed_executor_backend,
enforce_eager=True,
Expand Down
Loading