[CI/Build] drop support for Python 3.8 EOL

[aarnphm]

As Python 3.8 reaches EOL, this PR would be a starting point to remove potential code branch on 3.8 only.

I'm still working through all of the code, but this would be a starting point for CI.

Depends on #8469, and wait til PyTorch drop 3.8 support

---

PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

• [Bugfix] for bug fixes.
• [CI/Build] for build or continuous integration improvements.
• [Doc] for documentation fixes and improvements.
• [Model] for adding a new model or improving an existing model. Model name should appear in the title.
• [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
• [Kernel] for changes affecting CUDA kernels or other compute kernels.
• [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
• [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
• [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

• We adhere to Google Python style guide and Google C++ style guide.
• Pass all linter checks. Please use format.sh to format your code.
• The code need to be well-documented to ensure future contributors can easily understand the code.
• Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
• Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels

Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

• Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
• Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
• Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops. See tests/kernels for examples.
• When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
• If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

• After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
• After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
• After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
• Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

• Add ready label to the PR
• Enable auto-merge.

🚀

[DarkLight1337]

Do we have pyupgrade enabled in the settings for ruff? Would be great if we could use it to get rid of legacy code.

[aarnphm]

Do we have pyupgrade enabled in the settings for ruff? Would be great if we could use it to get rid of legacy code.

I think we can update to latest ruff and use pyupgrade. But I feel like that introduce a lot of merge conflict for other higher priority PR.

For these CI PR would probably be best to run before releasing a new version. What do you think?

ps: I can add ruff tool, but won't run it if that works better.

[DarkLight1337]

Currently we use yapf for formatting, and ruff only for linting. I think adding pyupgrade lint rules should not cause many changes to the code.

[DarkLight1337]

I think adding pyupgrade lint rules should not cause many changes to the code.

OK, I stand corrected... maybe we can turn on just a subset of the rules ?

[DarkLight1337]

In particular, f-string formatting seems to be responsible for most of the diffs, so try turning that off.

[aarnphm]

yes, will revert 182d0d7

[aarnphm]

fwiw https://docs.astral.sh/ruff/rules/#pyupgrade-up we can exclude f-string format?

[aarnphm]

Also are there any specific reason that we locked ruff to 0.1? it is pretty old?

[DarkLight1337]

Upgrading ruff may add new rules from the categories that we've currently enabled. Let's do that in a separate PR to avoid introducing a huge amount of diffs.

[DarkLight1337]

fwiw https://docs.astral.sh/ruff/rules/#pyupgrade-up we can exclude f-string format?

We can specify the rules to ignore inside the list in tool.ruff.lint.ignore.

[DarkLight1337]

Since we might not want to drop Python 3.8 immediately, it's probably better to work on upgrading ruff first in another PR.

[aarnphm]

#8469 cc @DarkLight1337

[DarkLight1337]

Now that Python 3.8 has reached EOL, let's resume work on this.

[DarkLight1337]

Heads up that PyTorch 2.5.0 has officially dropped Python 3.8 as well. Can you update this PR? (Probably easier to revert the non-CI/CD file changes and apply the linter on latest main)

[aarnphm]

yep I will revisit this this weekend, sorry work and other stuff got caught up

[DarkLight1337]

@aarnphm any update? Otherwise, we'll work on this issue in #10038 instead.

[aarnphm]

Oh I think I already push on my end

[DarkLight1337]

Please fix the linter errors. There are also a couple places where we use sys.version_info, so it would be great if you could prune the 3.8-only code!

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. @aarnphm please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[aarnphm]

cc @DarkLight1337 PTAL

[DarkLight1337]

Please take a look at the doc failure.

There are also a couple places where we use sys.version_info, so it would be great if you could prune the 3.8-only code!

And also this.

[aarnphm]

Hmm I already remove all sys.version_info compat for 3.8

[DarkLight1337]

Hmm I already remove all sys.version_info compat for 3.8

How about sys.version_info < (3, 9)?

[aarnphm]

hmm thats weird I thought I already fixed it, anw

[DarkLight1337]

Thanks for your hard work!