[Frontend] Create ErrorResponse instead of raising exceptions in run_batch #8347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…batch The run_batch API currently creates error responses for requests that fail inside the engine. Error responses appear in the output file indicating which request ID has failed. This PR makes sure error responses are also created for requests that fail due to invalid url endpoints or unsupported cases such as streaming.
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
DarkLight1337
approved these changes
Sep 11, 2024
github-actions
bot
added
the
ready
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Sep 12, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…batch (vllm-project#8347) Signed-off-by: Alvant <alvasian@yandex.ru>
garg-amit
pushed a commit
to garg-amit/vllm
that referenced
this pull request
Oct 28, 2024
…batch (vllm-project#8347) Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
LeiWang1999
pushed a commit
to LeiWang1999/vllm-bitblas
that referenced
this pull request
Mar 26, 2025
…batch (vllm-project#8347) Signed-off-by: LeiWang1999 <leiwang1999@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run_batch API currently creates error responses for requests that fail inside the engine. Error responses appear in the output file indicating which request ID has failed. This PR makes sure error responses are also created for requests that fail due to invalid url endpoints or unsupported cases such as streaming.