Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] tool calling support for ibm-granite/granite-20b-functioncalling #8339

Merged
merged 35 commits into from
Oct 29, 2024
Merged

[Model] tool calling support for ibm-granite/granite-20b-functioncalling #8339

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
58e468d
initial commit
wseaton Sep 10, 2024
d4cc66b
remove original part of template
wseaton Sep 10, 2024
742704f
clean up debug logging
wseaton Sep 10, 2024
410ff88
update docs; raise not implemented
wseaton Sep 10, 2024
a5e9a1f
fix lints
wseaton Sep 10, 2024
3d28b6d
sort imports
wseaton Sep 10, 2024
74c8cc7
yapf fixes
wseaton Sep 10, 2024
23a4ca3
another format change
wseaton Sep 10, 2024
1659236
update example prompt to be conversational instead of single turn
wseaton Sep 10, 2024
b1e09a8
update docs for template; link paper
wseaton Sep 10, 2024
e82b2a6
Merge remote-tracking branch 'upstream/main' into granite-fc
wseaton Sep 27, 2024
6b0eebb
add granite to test config
wseaton Sep 27, 2024
346d554
fixup json
wseaton Sep 27, 2024
24e49b8
Add stream support for Granite 20b Tool Use
maxdebayser Sep 27, 2024
86dead8
fix docs
maxdebayser Sep 27, 2024
113fbb6
more robust whispace handling
maxdebayser Sep 28, 2024
acecb6d
remove reference to defunct granite parser
wseaton Oct 2, 2024
86e8466
remove old template
wseaton Oct 2, 2024
43c8078
Update tests/tool_use/utils.py to remove dupe
wseaton Oct 7, 2024
6bf4a41
Merge remote-tracking branch 'upstream/main' into granite-fc
wseaton Oct 7, 2024
2e969c7
fix double import
wseaton Oct 7, 2024
e18219c
add completion request arg to abstract method
wseaton Oct 7, 2024
9a0321b
formatting fixes
wseaton Oct 7, 2024
078ab85
import sorts
wseaton Oct 7, 2024
0a031bf
appease yapf
wseaton Oct 7, 2024
c6a6b56
Apply suggestions from code review
wseaton Oct 16, 2024
defed52
remove redudant indents; add type hints to utils
wseaton Oct 17, 2024
5b78cea
Merge branch 'granite-fc' of github.com:wseaton/vllm into granite-fc
wseaton Oct 17, 2024
2d3b8fe
formatting churn
wseaton Oct 17, 2024
fe13b72
Merge branch 'main' into granite-fc
wseaton Oct 21, 2024
84e93bf
change to old style type aliasing
wseaton Oct 21, 2024
ae55760
Merge branch 'granite-fc' of github.com:wseaton/vllm into granite-fc
wseaton Oct 21, 2024
1277f0b
Doc reformat, add back missing line
wseaton Oct 25, 2024
738d003
Temporarily disable the granite20b-fc test task
wseaton Oct 25, 2024
a6e1bf9
Merge branch 'vllm-project:main' into granite-fc
wseaton Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
another format change
  • Loading branch information
@wseaton
wseaton committed Sep 10, 2024
commit 23a4ca3791937565ee2ef40259f18e1bbd720a58
4 changes: 2 additions & 2 deletions vllm/entrypoints/openai/tool_parsers/granite_tool_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ def extract_tool_calls(self,
start_of_json = match.end()
# end_index == the start of the next function call
# (if exists)
next_function_call_start = (matches[i + 1].start() if i +
1 < len(matches) else None)
next_function_call_start = (matches[i + 1].start() if
i + 1 < len(matches) else None)

# extract the full JSON object using bracket matching via
# start_of_json and optional end index
Expand Down
Loading