Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Propagate 'trust_remote_code' setting in internvl and minicpmv #8250

Merged
merged 21 commits into from
Sep 25, 2024
Merged

[BugFix] Propagate 'trust_remote_code' setting in internvl and minicpmv #8250

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
efc3a4f
respect trust_remote_code config
zifeitong Sep 6, 2024
42a3bc3
fix merge conflict
zifeitong Sep 6, 2024
99e27af
add qwen
zifeitong Sep 11, 2024
c2da03e
Address comments
zifeitong Sep 17, 2024
36dda08
WIP
zifeitong Sep 18, 2024
1c32467
pass test
zifeitong Sep 18, 2024
1186e71
cleanup
zifeitong Sep 18, 2024
f3b7cdf
Switch to input_mapper
zifeitong Sep 20, 2024
6a11c38
format
zifeitong Sep 20, 2024
d961b64
revert changes
zifeitong Sep 20, 2024
9c48ce1
Switch to squeeze
zifeitong Sep 20, 2024
f6fde2b
Update vllm/model_executor/models/minicpmv.py
zifeitong Sep 20, 2024
02212e8
Update vllm/model_executor/models/minicpmv.py
zifeitong Sep 20, 2024
4224be5
address comments
zifeitong Sep 20, 2024
46a5079
allow empty list
zifeitong Sep 20, 2024
39d1534
Test passed
zifeitong Sep 24, 2024
d6c4243
cleanup
zifeitong Sep 24, 2024
1720cd6
cleanup
zifeitong Sep 24, 2024
7307fed
Fix batch inference
zifeitong Sep 24, 2024
e3a3184
fix format
zifeitong Sep 25, 2024
c8f1011
Address comments
zifeitong Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix batch inference
  • Loading branch information
@zifeitong
zifeitong committed Sep 24, 2024
commit 7307fed6d9a06b61258fec37b37cf045adc4180d
8 changes: 4 additions & 4 deletions vllm/model_executor/models/minicpmv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,11 +463,11 @@ def _get_image_bounds(self,
im_end_id: torch.Tensor,
slice_start_id: Optional[torch.Tensor] = None,
slice_end_id: Optional[torch.Tensor] = None) -> torch.Tensor:
start_cond = input_ids == im_start_id.item()
end_cond = input_ids == im_end_id.item()
start_cond = input_ids == im_start_id[0]
end_cond = input_ids == im_end_id[0]
if slice_start_id is not None:
start_cond |= (input_ids == slice_start_id.item())
end_cond |= (input_ids == slice_end_id.item())
start_cond |= (input_ids == slice_start_id[0])
end_cond |= (input_ids == slice_end_id[0])

image_start_tokens, = torch.where(start_cond)
image_start_tokens += 1
Expand Down
Loading