Skip to content

Conversation

elfiegg
Copy link
Contributor

@elfiegg elfiegg commented Sep 5, 2024

As per FlashInfer doc, q_data_type will be set to KV cache's data_type if not explicitly set, which results in RuntimeError: BatchPrefillWithPagedKVCachePyTorchWrapper::BeginForward(at::Tensor, at::Tensor, at::Tensor, at::Tensor, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, at::Tensor)::<lambda()> failed to dispatch data type Float8_e4m3fn.

cc @pavanimajety @yzh119

Copy link

github-actions bot commented Sep 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
Also cc @yzh119

@comaniac comaniac enabled auto-merge (squash) September 5, 2024 01:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 5, 2024
@comaniac comaniac merged commit e39ebf5 into vllm-project:main Sep 5, 2024
69 of 70 checks passed
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
LeiWang1999 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants