[Bugfix] Pass PYTHONPATH from setup.py to CMake #7730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
|
/ready |
github-actions
bot
added
the
ready
mgoin
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Thanks for the PR, this seems reasonable. FYI @LucasWilkinson just because it involved machete
6 tasks
omrishiv
pushed a commit
to omrishiv/vllm
that referenced
this pull request
Aug 26, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In clean build environments such as
cibuildwheel, build dependencies are installed in a virtual environment located at/tmp/pip-build-env-xxx. This path is in thePYTHONPATHof thesetup.pyfile, but it is not passed to CMake and subsequent Python calls. This PR fixes this behavior by passing thePYTHONPATHfromsetup.pyto CMake, and finally to themachete/generate.pyscript (which usesjinja2from build dependencies).