-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix default weight loading for scalars #7534
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've been faced to this several times...
Signed-off-by: Alvant <alvasian@yandex.ru>
It is pretty easy to run into issues when loading scalar weights from checkpoints into parameters, since they can have no shape in some cases, resulting in errors like
I think it makes sense to detect and allow "broadcasting" in this special case for ease of use.