-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build] Add text-only test for Qwen models #7475
[CI/Build] Add text-only test for Qwen models #7475
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
c52c052
to
611e37b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a test! Keep in mind though that we're trying to slim down on the number of model tests to be run in CI, so your test might be deactivated in a future PR (can still run on demand).
Seems that Qwen test requires an additional dependency. |
FYI we do test Qwen text LLMs in a few places, just not the VL style mentioned here vllm/.buildkite/lm-eval-harness/configs/models-small.txt Lines 8 to 9 in d3d9cb6
vllm/tests/models/test_gguf.py Line 27 in d3d9cb6
|
Head branch was pushed to by a user without write access
097acb8
to
eee043a
Compare
Thanks @DarkLight1337, that makes sense! And whoops, I forgot that it needs Thanks for the heads up @mgoin! I did look a bit, but I didn't see any |
We need to resolve those dependency errors sooner or later since they will occur in the VLM test as well. Based on the test failures, looks like vllm/.buildkite/run-cpu-test.sh Line 25 in 22b39e1
|
eee043a
to
c6a1fed
Compare
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
c6a1fed
to
0cc3f77
Compare
Thanks for the guidance @DarkLight1337! I've updated the deps and rebased the branch :) |
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Alvant <alvasian@yandex.ru>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Hello! I noticed that there aren't any model tests for
QwenModel
yet, and was wondering if there was a reason for this, or if it would make sense to add one similar to the other tests running on the example test prompts.I am working on extending
QwenModel
, which currently skips loading the visual component of models likeQwen/Qwen-VL
in VLLM so that it can handle text-only inputs, to accept visual inputs. I thought it would be a good idea to potentially add a test for text-only inputs, which could potentially be updated to include visual inputs once that is at a point that it's ready for a look.It's also probably worth noting that there are some small differences in the produced output for a few of the example prompts, although the produced sequences start the same and are quite close, so maybe it's not an issue. For example:
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!