Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc][plugin] add plugin system implementation #7426

Merged
merged 40 commits into from
Aug 13, 2024

Conversation

youkaichao
Copy link
Member

follows #7131

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao requested a review from simon-mo August 12, 2024 17:19
vllm/utils.py Outdated Show resolved Hide resolved
@youkaichao
Copy link
Member Author

@DarkLight1337 this pr should be much simplier now, I moved the opt model files to dynamic download, without adding it to our codebase.

@youkaichao youkaichao requested a review from simon-mo August 13, 2024 18:28
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very quick README in vllm/plugins will be useful. Also i do find the term general to be not very informative. just call it VLLM_PLUGINS is good enough. But leaving it all to you. The code itself looks fine for me. I also like the fact that it doesn't break existing OOT registration flow rather sit on top of it.

@youkaichao
Copy link
Member Author

Also i do find the term general to be not very informative. just call it VLLM_PLUGINS is good enough

@simon-mo changed in b03ab18

@youkaichao
Copy link
Member Author

A very quick README in vllm/plugins will be useful.

doc change will come later.

@Pinkypoopoo
Copy link

Pinkypoopoo commented Aug 13, 2024 via email

@youkaichao
Copy link
Member Author

fixes #5657

@youkaichao youkaichao merged commit 16422ea into vllm-project:main Aug 13, 2024
18 of 21 checks passed
@youkaichao youkaichao deleted the entrypoint_plugin branch August 13, 2024 23:24
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants