-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc][plugin] add plugin system implementation #7426
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
@DarkLight1337 this pr should be much simplier now, I moved the opt model files to dynamic download, without adding it to our codebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very quick README in vllm/plugins
will be useful. Also i do find the term general
to be not very informative. just call it VLLM_PLUGINS
is good enough. But leaving it all to you. The code itself looks fine for me. I also like the fact that it doesn't break existing OOT registration flow rather sit on top of it.
doc change will come later. |
Unsubscribe
…On Wed, 14 Aug, 2024, 4:19 am youkaichao, ***@***.***> wrote:
A very quick README in vllm/plugins will be useful.
doc change will come later.
—
Reply to this email directly, view it on GitHub
<#7426 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCU643VUQYGOS53JUTWTPMDZRKEQ7AVCNFSM6AAAAABMMSSDJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBXGMYDSMJRGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
fixes #5657 |
Signed-off-by: Alvant <alvasian@yandex.ru>
follows #7131